Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: WebUI doesn't sort by new option AlbumPlayCountMode normalized #2984

Closed
3 tasks done
metalheim opened this issue Apr 29, 2024 · 4 comments
Closed
3 tasks done
Labels
bug triage New bug reports that need to be evaluated

Comments

@metalheim
Copy link
Contributor

I confirm that:

  • I have searched the existing open AND closed issues to see if an issue already exists for the bug I've encountered
  • I'm using the latest version (your issue may have been fixed already)

Version

0.52.0

Current Behavior

In the WebUI, the "Most played" Albums tab doesnt sort correctly if the new configuration option AlbumPlayCountMode is set to "normalized".
Configuration seems to correctly "normalize" the playcount values (otherwise, the albums in below screenshots would have hundreds of plays), but sorting this column is off.

image

As you can see, it shows an album with 10 plays as first, but then two albums with 3 play and then albums with >1 play.

Expected Behavior

Sorting by Playcount in WebUI should work the same way as it does with AlbumPlayCountMode set to "absolute" (just with different playcounts of course)

Steps To Reproduce

  1. Have albums with lots of plays and lots of tracks
  2. Set AlbumPlayCountMode to "normalized"
  3. go to WebUI tab "Most Played"
  4. Sorting is wrong

Environment

- OS: Synology DSM7.2 - Navidrome install through Docker
- Browser: Latest Chrome and Latest MS Edge
- Client: WebUI

How Navidrome is installed?

Docker

Configuration

[..]                                                                                                                                                                                                               AlbumPlayCountMode="normalized"
[..]

Relevant log output

No response

Anything else?

No response

Code of Conduct

  • I agree to follow Navidrome's Code of Conduct
@metalheim metalheim added bug triage New bug reports that need to be evaluated labels Apr 29, 2024
@metalheim
Copy link
Contributor Author

Could a full scan help here?
I'm hesitant to just launch a full scan, as it takes quite long with my library size+processor power combination.

@deluan
Copy link
Member

deluan commented Apr 29, 2024

Ops, my bad! The implementation is incomplete as it does not use the calculated album play count to sort or filter in smart playlists. I'll work on this and release a patch version soon.

@rombat
Copy link

rombat commented Apr 30, 2024

Ops, my bad! The implementation is incomplete as it does not use the calculated album play count to sort or filter in smart playlists. I'll work on this and release a patch version soon.

Thanks ! I had the exact same problem and was wondering why.
And by the way, thanks a lot for this feature 👍🏼

@deluan deluan closed this as completed in a8955f2 May 2, 2024
@deluan
Copy link
Member

deluan commented May 2, 2024

Should be fixed in the latest develop, please let me know. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug triage New bug reports that need to be evaluated
Projects
None yet
Development

No branches or pull requests

3 participants