-
-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starting a playlist from a specific song only adds the remainder of the playlist to the queue (Web UI) #703
Comments
Sorry for the delay. Yes this was necessary when I first implemented the play queue management, as the upstream react-player project didn't have better ways to manipulate the queue. It changed in recent versions, so I may take another look and see if this can be improved. |
Sure, you want me to keep this open until you see if its possible now? |
Yes, let's keep this open. I'll try to take a look at this this week |
This should be fixed in ace5c90. Please test the latest build and let me know. |
Works as desired in ace5c90. Thanks a lot 👍🏼 This is one of those things that I do a lot that works the same way in all the other players I used which breaks Jakob's Law like you mentioned. |
Thanks @YashJipkate for your previous PR #976, you were right: The "Play Next" behaviour is already broken in master, it is a bug in the React Player. I'll open an issue with that project and will try to fix it this weekend. |
There is an issue already opened by me, you might want to take a look at lijinke666/react-music-player#349. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The expected behaviour was that when I start playing a playlist from a specific song, the whole playlist is added to the queue and the specific song starts playing. That way, I can still go the previous song in the playlist since it is all in the queue.
However, in the Web UI, only the songs after the specific song are added to the queue.
This is not the case in Music Stash nor DSub.
The text was updated successfully, but these errors were encountered: