expose form values to parent component #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audiolion
reviewed
Aug 12, 2017
tests/expose-values.js
Outdated
| @@ -0,0 +1,43 @@ | |||
| //Test things dealing with the initialValues prop | |||
audiolion
reviewed
Aug 12, 2017
tests/expose-values.js
Outdated
| error ? <p className="error">{error}</p> : <input {...props} />; | ||
|
|
||
| test('Form passes values to onValues', () => { | ||
| const onValues = spy(); |
There was a problem hiding this comment.
jest has its own spy, do you just prefer sinon's implementation?
There was a problem hiding this comment.
ooo i used it back before i used jest and didnt bother to look and see. maybe ill make a pr where i remove it soon. You're welcome to if you want as well.
audiolion
reviewed
Aug 12, 2017
README.md
Outdated
|
|
||
| **initialValues** | ||
| exposes the values on change, you must manage the form state by passing in values if using this. |
There was a problem hiding this comment.
I might say passing in state to the ``values`` prop if using this. to make it more obvious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@audiolion thoughts? Should be good to go :)