Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update RO with energy recovery flowsheet #100

Merged
merged 1 commit into from
Jun 4, 2021
Merged

update RO with energy recovery flowsheet #100

merged 1 commit into from
Jun 4, 2021

Conversation

TimBartholomew
Copy link
Contributor

@TimBartholomew TimBartholomew commented Jun 4, 2021 •
edited

Fixes/Addresses:

None

Summary/Motivation:

Since the RO with energy recovery flowsheet demonstrates the capabilities of Proteuslib, it should include the most detailed calculations that are appropriate. Additionally, since the RO model is less stable with the more detailed calculations this flowsheet acts as another use case test.

Changes proposed in this PR:

  • Updated RO with energy recovery flowsheet to use calculated concentration polarization and pressure drop

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@TimBartholomew TimBartholomew added the Priority:Normal Normal Priority Issue or PR label Jun 4, 2021
@TimBartholomew TimBartholomew self-assigned this Jun 4, 2021
bknueven
bknueven approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@bknueven bknueven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable, and I agree that this flow sheet should demonstrate our flagship capability in RO modeling.

adam-a-a
adam-a-a approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@adam-a-a adam-a-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimBartholomew TimBartholomew merged commit 13777ef into watertap-org:main Jun 4, 2021
@TimBartholomew TimBartholomew deleted the update_RO_flowsheet branch June 22, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-a-a adam-a-a adam-a-a approved these changes

@bknueven bknueven bknueven approved these changes

@OOAmusat OOAmusat Awaiting requested review from OOAmusat

Assignees

@TimBartholomew TimBartholomew

Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TimBartholomew @adam-a-a @bknueven