Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RO Membrane Channel Cleanup #716

Merged
merged 4 commits into from
Oct 18, 2022
Merged

RO Membrane Channel Cleanup #716

merged 4 commits into from
Oct 18, 2022

Conversation

bknueven
Copy link
Contributor

@bknueven bknueven commented Sep 9, 2022

Fixes/Resolves: N/A

Summary/Motivation:

Cleanup in RO unit models from #245 -- lots of attributes were moved to the membrane channel, this PR completes the move in the remainder of the WaterTAP codebase

Changes proposed in this PR:

  • delete most references on RO unit models
  • update WaterTAP to use attributes on feed_side
  • update RO documention

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #716 (fc09d78) into main (92f6ab3) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #716      +/-   ##
==========================================
- Coverage   95.63%   95.63%   -0.01%     
==========================================
  Files         254      254              
  Lines       24342    24327      -15     
==========================================
- Hits        23280    23265      -15     
  Misses       1062     1062              
Impacted Files Coverage Δ
...ith_energy_recovery/monte_carlo_sampling_RO_ERD.py 96.96% <ø> (ø)
watertap/examples/flowsheets/lsrro/multi_sweep.py 95.18% <ø> (ø)
watertap/unit_models/reverse_osmosis_0D.py 98.50% <ø> (ø)
...RO_with_energy_recovery/RO_with_energy_recovery.py 91.01% <100.00%> (ø)
...awater_RO_desalination/seawater_RO_desalination.py 95.25% <100.00%> (ø)
...covery/dye_desalination/dye_desalination_withRO.py 99.67% <100.00%> (ø)
...er_resource_recovery/dye_desalination/dye_sweep.py 97.75% <100.00%> (ø)
...treatment_train/analysis/flowsheet_single_stage.py 96.15% <100.00%> (ø)
...ll_treatment_train/analysis/flowsheet_two_stage.py 92.30% <100.00%> (ø)
...full_treatment_train/model_components/unit_0DRO.py 91.11% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lbianchi-lbl lbianchi-lbl added this to Unprioritized in WaterTAP Priorities Sep 15, 2022
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Sep 15, 2022
@ksbeattie ksbeattie removed this from Unprioritized in WaterTAP Priorities Sep 15, 2022
Copy link
Contributor

@adam-a-a adam-a-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adam-a-a adam-a-a merged commit 4331107 into watertap-org:main Oct 18, 2022
@bknueven bknueven deleted the ro_names branch September 22, 2023 22:10
lbianchi-lbl pushed a commit to watertap-org/parameter-sweep that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants