Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Check snap for Preview Time #24

Closed
dudehacker opened this issue Jun 19, 2022 · 1 comment
Closed

[Feature Request] Check snap for Preview Time #24

dudehacker opened this issue Jun 19, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@dudehacker
Copy link

kinda minor thing but can you detect if preview time is snapped or not.

sometimes after audio change, cause offset shift and mapper forget to shift the preview by like 5-10ms

some mapper are perfectionist and will self DQ for this change:
https://osu.ppy.sh/beatmapsets/1696523/discussion/-/generalAll#/3141891

would be nice to add if not too much trouble.
can use warning, not problem, could be intentional unsnapped.

@Naxesss
Copy link
Owner

Naxesss commented Jun 27, 2022

Warning for unsnapped preview times would yield too many false positives, as this generally isn't an issue, and it definitely wouldn't be a notable DQ if DQed for (or at least I hope not).

Ideally you'd want to tie this in with snapshots: If the uninherited line where the preview point existed was moved, and the preview point is now unsnapped, ask whether they forgot to move it. But no check currently ties in with snapshots and it seems a bit overkill to implement for this.

So will leave this to others to add as a custom check if they want it.

@Naxesss Naxesss closed this as completed Jun 27, 2022
@Naxesss Naxesss added the enhancement New feature or request label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants