Fails to build from current gits

[3vi1]

I build this from git ever few weeks, and it's been working fine until now. After updating both projecttox-core and venom recently, it seems like venom might not be up-to-date with the latest tox changes.

/home/evil/src/venom/build/src/core/ToxSession.c: In function ‘venom_tox_session_join_groupchat’:
/home/evil/src/venom/build/src/core/ToxSession.c:3222:14: error: too few arguments to function ‘tox_join_groupchat’
    _tmp10_ = tox_join_groupchat (_tmp3_, (gint32) _tmp6_, _tmp9_);
              ^
In file included from /home/evil/src/venom/build/src/core/ToxSession.c:30:0:
/usr/local/include/tox/tox.h:491:5: note: declared here
 int tox_join_groupchat(Tox *tox, int32_t friendnumber, const uint8_t *data, uint16_t length);
     ^
src/CMakeFiles/venom.dir/build.make:607: recipe for target 'src/CMakeFiles/venom.dir/core/ToxSession.c.o' failed
make[2]: *** [src/CMakeFiles/venom.dir/core/ToxSession.c.o] Error 1

[ghost]

Same here.
Tox is checkout on commit 627e4d3aa
Venom is checkout on commit c260230

+ export CC=gcc
++ CC=gcc
++ export CXX=g++
++ CXX=g++
++ FLAGS='-O2 -fPIC -pipe'
++ LIBDIRSUFFIX=64
++ export USE_ARCH=64
++ USE_ARCH=64
++ export 'LDFLAGS=-L/usr/lib64 -Wl,-O1,--as-needed,--sort-common'
++ LDFLAGS='-L/usr/lib64 -Wl,-O1,--as-needed,--sort-common'
++ export PKG_CONFIG_PATH=/usr/lib64/pkgconfig
++ PKG_CONFIG_PATH=/usr/lib64/pkgconfig
+ mkdir -p build
+ cd build
+ CFLAGS='-O2 -fPIC -pipe'
+ CXXFLAGS='-O2 -fPIC -pipe'
+ cmake -D CMAKE_BUILD_TYPE=Release -D CMAKE_INSTALL_PREFIX=/usr -D LIB_SUFFIX=64 ..
-- The C compiler identification is GNU 4.8.3
-- Check for working C compiler: /usr/bin/gcc
-- Check for working C compiler: /usr/bin/gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
Venom version 0.2.0
64 bit architecture detected.
-- Found Vala: /usr/bin/valac (found version "0.25.3") 
-- Found Vala: /usr/bin/valac (found suitable version "0.25.3", minimum required is "0.18.1") 
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.28") 
-- checking for module 'gtk+-3.0>=3.4'
--   found gtk+-3.0, version 3.12.2
-- checking for module 'gio-2.0>=2.32'
--   found gio-2.0, version 2.40.0
-- checking for module 'glib-2.0>=2.32'
--   found glib-2.0, version 2.40.0
-- checking for module 'sqlite3>=3.7'
--   found sqlite3, version 3.8.6
-- checking for module 'json-glib-1.0>=0.14'
--   found json-glib-1.0, version 0.16.2
-- checking for module 'libtoxcore>=0.0'
--   found libtoxcore, version 0.0.0
Optional features / dependencies:
   [ ] ENABLE_DJBDNS - resolve tox dns ids using djbdns (required for glib <= 2.32)
   [ ] ENABLE_QR_ENCODE - show QR codes (requires libqrencode)
   [ ] ENABLE_LIBNOTIFY - libnotify notification support
-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

    LIB_SUFFIX


-- Build files have been written to: /tmp/0-marmite/venom/sources/venom-c2602307f0/build
+ make -j5
[  1%] [  3%] [  5%] Scanning dependencies of target translations
Generating pixmaps/venom_pixmaps.gresource.c
Generating Main.c, core/Contact.c, core/ContactStorage.c, core/DhtNode.c, core/DhtNodeStorage.c, core/FileTransfer.c, core/GroupChat.c, core/GroupChatContact.c, core/Logger.c, core/MessageLog.c, core/Message.c, core/Notification.c, core/ResourceFactory.c, core/Settings.c, core/SqliteTools.c, core/Tools.c, core/ToxDns.c, core/ToxSession.c, core/User.c, ui/AboutDialog.c, ui/AddContactDialog.c, ui/ChatMessage.c, ui/Client.c, ui/ContactFilter.c, ui/ContactListCellRenderer.c, ui/ContactListTreeView.c, ui/ContactListWindow.c, ui/ConversationTextView.c, ui/ConversationView.c, ui/ConversationWidget.c, ui/EditableLabel.c, ui/FileTransferChatEntry.c, ui/GroupConversationSidebar.c, ui/GroupConversationWidget.c, ui/MessageTextView.c, ui/PinDialog.c, ui/SearchEntry.c, ui/UserInfoWindow.c, ui/UITools.c, ui/SettingsWindow.c
Generating ui/venom.gresource.c
[  7%] [  9%] Generating zh_CN.mo
Generating de.mo
[ 11%] Generating es.mo
[ 13%] [ 15%] Generating it.mo
Generating ru.mo
[ 17%] Creating translations.
[ 17%] Built target translations
/tmp/0-marmite/venom/sources/venom-c2602307f0/src/ui/AboutDialog.vala:41.44-41.61: error: Argument 2: Cannot convert from `string' to `string[]'
      this.add_credit_section("Packagers", (string) packagers);
                                           ^^^^^^^^^^^^^^^^^^
Compilation failed: 1 error(s), 0 warning(s)
make[2]: *** [src/Main.c] Error 1
src/CMakeFiles/venom.dir/build.make:95: recipe for target 'src/Main.c' failed
CMakeFiles/Makefile2:157: recipe for target 'src/CMakeFiles/venom.dir/all' failed
make[1]: *** [src/CMakeFiles/venom.dir/all] Error 2
make: *** [all] Error 2
Makefile:136: recipe for target 'all' failed
+ make
[  1%] Generating Main.c, core/Contact.c, core/ContactStorage.c, core/DhtNode.c, core/DhtNodeStorage.c, core/FileTransfer.c, core/GroupChat.c, core/GroupChatContact.c, core/Logger.c, core/MessageLog.c, core/Message.c, core/Notification.c, core/ResourceFactory.c, core/Settings.c, core/SqliteTools.c, core/Tools.c, core/ToxDns.c, core/ToxSession.c, core/User.c, ui/AboutDialog.c, ui/AddContactDialog.c, ui/ChatMessage.c, ui/Client.c, ui/ContactFilter.c, ui/ContactListCellRenderer.c, ui/ContactListTreeView.c, ui/ContactListWindow.c, ui/ConversationTextView.c, ui/ConversationView.c, ui/ConversationWidget.c, ui/EditableLabel.c, ui/FileTransferChatEntry.c, ui/GroupConversationSidebar.c, ui/GroupConversationWidget.c, ui/MessageTextView.c, ui/PinDialog.c, ui/SearchEntry.c, ui/UserInfoWindow.c, ui/UITools.c, ui/SettingsWindow.c
/tmp/0-marmite/venom/sources/venom-c2602307f0/src/ui/AboutDialog.vala:41.44-41.61: error: Argument 2: Cannot convert from `string' to `string[]'
      this.add_credit_section("Packagers", (string) packagers);
                                           ^^^^^^^^^^^^^^^^^^
Compilation failed: 1 error(s), 0 warning(s)
make[2]: *** [src/Main.c] Error 1
src/CMakeFiles/venom.dir/build.make:95: recipe for target 'src/Main.c' failed
CMakeFiles/Makefile2:157: recipe for target 'src/CMakeFiles/venom.dir/all' failed
make[1]: *** [src/CMakeFiles/venom.dir/all] Error 2
Makefile:136: recipe for target 'all' failed
make: *** [all] Error 2

[prurigro]

I can confirm the break as well, and will add that I've traced the breaking change to commit 964fcac of toxcore (comment is "Removed useless code from groupchats.", but maybe the code wasn't so useless?).

Cheers!

[naxuroqa]

I updated the vapi (Vala bindings for c-libraries), so it should work again.
Please reopen if you still run into building errors

[ghost]

Builds OK now, thank you!