Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprites updated with HDMA differs from hardware #130

Closed
GValiente opened this issue Sep 3, 2020 · 7 comments
Closed

Sprites updated with HDMA differs from hardware #130

GValiente opened this issue Sep 3, 2020 · 7 comments
Assignees

Comments

@GValiente
Copy link

Test rom:
test.zip

The first sprite lines in the image with length = 64 pixels are not shown on hardware.
Those lines are present in the last line of the sprite's image data.

test

@fleroviux
Copy link
Member

@GValiente can you provide source code to this test? this would make it a lot easier to debug for me.

@GValiente
Copy link
Author

The test has been built on top on an engine that I'm planning to release at the end of this year, so if you don't mind to wait a few months I'll release the source code of this test with it.

If you can't wait, I can release part of the issues' related code. I think that the issue is related with that hdma on hardware in my rom seems to be two horizontal lines late, instead of only one.

@fleroviux
Copy link
Member

I'm a bit confused how many lines are actually supposed to be missing on HW:
image
this is what I get on my GBA SP (sorry for the poor lighting condition). Can you confirm that all sprite lines with width=64 should be missing as seen on the image?

If you can't wait, I can release part of the issues' related code. I think that the issue is related with that hdma on hardware in my rom seems to be two horizontal lines late, instead of only one.

I guess that might help but I had hoped to be able to make changes and test them on HW.

@GValiente
Copy link
Author

GValiente commented Sep 4, 2020

Yep, those are the lines that are missing, the top ones with width=64, which are rendered with the last line of the sprite's tiles:

https://cdn.discordapp.com/attachments/312199400875360256/749564712437678160/example.png

@GValiente
Copy link
Author

New test ROM.

The two biggest lines in the middle of the diamond are not visible on a real GBA:

nba

The source code of the test ROM is available here.

@fleroviux
Copy link
Member

Thanks!

@fleroviux
Copy link
Member

Bildschirmfoto 2021-02-07 um 01 08 05

Bildschirmfoto 2021-02-07 um 01 08 24

This should perfectly match hardware now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants