Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OBJ palette fetches and horizontal mosaic should likely not be done one scanline ahead #208

Closed
fleroviux opened this issue Mar 30, 2022 · 0 comments · Fixed by #276
Closed

OBJ palette fetches and horizontal mosaic should likely not be done one scanline ahead #208

fleroviux opened this issue Mar 30, 2022 · 0 comments · Fixed by #276
Assignees
@fleroviux
Labels
accuracy hw: ppu

Comments

@fleroviux
Copy link
Member

fleroviux commented Mar 30, 2022 •
edited
Loading

Right now we render OBJs one scanline ahead into a buffer, as hardware seems to do.
However in the same scanline we also fetch the palette data and apply horizontal mosaic. I think that this might not be accurate, therefore: research what the correct behaviour is and implement it.
@fleroviux fleroviux self-assigned this Mar 30, 2022
@fleroviux fleroviux linked a pull request Feb 20, 2023 that will close this issue
PPU: implement a cycle-accurate renderer (Version 2.0) #276
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fleroviux fleroviux

Labels
accuracy hw: ppu
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PPU: implement a cycle-accurate renderer (Version 2.0) nba-emu/NanoBoyAdvance
1 participant
@fleroviux