Video is not correct in Final Fantasy 1 and 2

[branchus]

Windows 11 Pro - NanoBoyAdvance 1.7
Notice the bottom area, the video is not correct.

How to reproduce
start the game, have couple fights, come back to village try to talk to any npc

[branchus]

Two more screenshots, seem it can be on bottom as well as on top.

[fleroviux]

This appears to be a regression from NBA 1.6. Possibly related to the PPU rewrite.

[fleroviux]

Looks like 1fbe80b is the regressing commit.

[fleroviux]

This was caused by a really old oversight in my code that somehow was not triggered until this recent change.

If the CPU is halted the code would check if there are any DMAs to execute and then fast-forward in time to the next hardware event. It would then check if the CPU should wake up. However it is possible that the condition for waking up the CPU becomes true during the DMA, which means that still fast-forwarding to the next event is incorrect in that case.

The fix addresses this by checking if the CPU should wake up after executing a DMA and not skipping to the next event in that case.

The corruptions should be fixed in the latest dev builds.