Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pokemon Radical Red crashes when Squawkabilly is sent out w/ HQ audio on #362

Closed
sukerokushin opened this issue Feb 25, 2024 · 1 comment

Comments

@sukerokushin
Copy link

sukerokushin commented Feb 25, 2024

Tested on Radical Red v4.0, Windows 11

Test save: go down and to the left here, start the fight with Camper Ricky—he always leads with Squawkabilly

@fleroviux
Copy link
Member

It seems that this ROM hack is missing the Pokemon cry for Squawkabilly, so when trying to play its cry, the wave data will point to NULL. This rightfully triggered an assert in the code, as this should not happen normally. I have pushed a workaround that handles broken wave data by preventing the broken sound channel from playing.

If you check the latest dev build it should be working now:
https://github.com/nba-emu/NanoBoyAdvance/actions/runs/8034632962

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants