Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boktai: Solar sensor is not working on current master #370

Closed
raphaelr opened this issue Mar 31, 2024 · 3 comments
Closed

Boktai: Solar sensor is not working on current master #370

raphaelr opened this issue Mar 31, 2024 · 3 comments

Comments

@raphaelr
Copy link
Contributor

Steps to reproduce:

  1. Load a Boktai ROM and start a new game
  2. Adjust the solar level using Config -> System -> Solar sensor level
  3. The "Current level:" label updates, but nothing changes in-game

core is null here:

if(core) {
auto solar_sensor = core->GetROM().GetGPIODevice<nba::SolarSensor>();
if(solar_sensor) {
solar_sensor->SetLightLevel(level);
}
}

@fleroviux
Copy link
Member

Oh, that's a regression from a recent refactor. I should be able to push a fix tomorrow/later today.

@fleroviux
Copy link
Member

@raphaelr this should be fixed now in the latest development build. Let me know if it's fixed for you. In that case I will release a minor version with the fix.

@raphaelr
Copy link
Contributor Author

raphaelr commented Apr 2, 2024

I tested it, and it works again. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants