Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ServiceDefinition concepts #9

Open
charphi opened this issue Oct 7, 2019 · 3 comments
Open

Refactor ServiceDefinition concepts #9

charphi opened this issue Oct 7, 2019 · 3 comments
Labels
enhancement New feature or request
Milestone
2.0.0

Comments

@charphi
Copy link
Member

charphi commented Oct 7, 2019 •
edited

Merge mutability and singleton concepts into a higher level of abstraction to avoid invalid use cases such as thread-unsafe singleton.
@charphi charphi added the enhancement New feature or request label Oct 7, 2019
@charphi
Copy link
Member Author

charphi commented Oct 7, 2019

New concept Old concept
IMMUTABLE NONE
MUTABLE BASIC
CONCURRENT CONCURRENT
CONSTANT NONE + singleton
ATOMIC CONCURRENT + singleton

@charphi charphi added this to the 2.0.0 milestone Oct 7, 2019
@charphi
Copy link
Member Author

charphi commented Oct 8, 2019

Warning on thread-unsafe singleton added in b28a43e

@charphi charphi changed the title Refactor mutability and singleton parameters Refactor ServiceDefinition concepts Oct 9, 2019
@charphi
Copy link
Member Author

charphi commented Oct 9, 2019

mutability + singleton could be named lifecycle.
preprocessor concept is also too vague and could be renamed selector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@charphi