Skip to content
This repository has been archived by the owner on Jun 16, 2020. It is now read-only.

Feature request: Pause button #27

Closed
PetterS opened this issue Jul 4, 2018 · 11 comments
Closed

Feature request: Pause button #27

PetterS opened this issue Jul 4, 2018 · 11 comments
Labels
enhancement New feature or request

Comments

@PetterS
Copy link

PetterS commented Jul 4, 2018

For all recordings except really simple ones, I think a pause button will be useful. It will let users copy text etc. I expect that this would require embedded JS, though.

Combined with a progress bar for seeking etc., this feature would be even better.

@nbedos
Copy link
Owner

nbedos commented Jul 4, 2018

I agree, not being able to pause the animation is annoying. I'll look into it.

@nbedos nbedos added the enhancement New feature or request label Jul 4, 2018
@vuuv
Copy link

vuuv commented Jul 5, 2018

@ylmrx
Copy link

ylmrx commented Jul 5, 2018

currently working on this.

@ylmrx
Copy link

ylmrx commented Jul 5, 2018

https://github.com/ylmrx/termtosvg/blob/ylmrx-patch-1/playpause.svg
What do you think ?
(right-click > display image). (see the red/green button upper right)
I need to implement the option to enable / disable it from CLI.
I don't want to embed some image, or have an ugly text, the color code seems the best and most straightforward to me. If you or @nbedos has a better idea, advise.

@PetterS
Copy link
Author

PetterS commented Jul 5, 2018

Nice! It works for me in Chrome and Firefox. But perhaps you can use Unicode ⏸ and ▶ for displaying the buttons? Or does that qualify as "ugly text"?

@ylmrx
Copy link

ylmrx commented Jul 5, 2018

ugly text meant "[PAUSE]" :)
I guess all browsers which can SVG shouldn't fail to hard with these (basic) unicodes. It display like this now : https://github.com/ylmrx/termtosvg/blob/ylmrx-patch-1/termtosvg_k65gm89m.svg
I have to clean the code, and make a PR later this week ! Stay tuned :D

@ylmrx
Copy link

ylmrx commented Jul 9, 2018

I wasn't able to make it before end of week, but here it is :

<3

#45

@nbedos
Copy link
Owner

nbedos commented Jul 9, 2018

Here's the slider I'd like to add too.

You have to click on the red square to catch it and then you can slide it left or right to explore the whole timeline.

I know nothing about JS though so this part of the code will need some serious review.

awesome.svg.zip

@styfle
Copy link

styfle commented Jul 9, 2018

@nbedos I can review JS. I already took a look at #45 and left some comments.

@ylmrx
Copy link

ylmrx commented Jul 9, 2018

The slider needs quite some work (I don't know much about JS in such context). And will probably need deep modifications within render_anim() function.
I feel it should be adressed in another issue ( #24 ). Still I love where this is going !

@nbedos
Copy link
Owner

nbedos commented Jul 29, 2018

This use case will be covered by SVG templates. See #53 for further discussion.

@nbedos nbedos closed this as completed Jul 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants