Document model V0 + UI/Engine Syncing with Redux + Project structuring #10

tonyketcham · 2022-04-06T00:49:18Z

Adds Redux as the central state manager
Seeds the design of the document model
- initial design in docs/audio-graph.md
  - https://whimsical.com/project-HNvThW62PrN9Gp33UfAuRf@2Ux7TurymNHcs4gAfi4M
Adds TS and Rust CI linting jobs

package.json

docs/audio-graph.md

- implementing redux slices for backend functions - creating basic input components - start topbar component - move functionality and state out of App.tsx - make eslint less annoying - move a lot of deps to devDependencies in package.json - temporarily removing nanoid from dependencies (at least until needed) - cleaning up App.tsx a lot - implementing runtime formatting functions - add util module Changes committed: modified: .eslintrc.cjs modified: backend/src/main.rs new file: backend/src/util/format.rs new file: backend/src/util/mod.rs modified: package.json modified: src/App.tsx new file: src/components/common/Button.tsx new file: src/components/common/Input.tsx new file: src/components/common/base/ButtonBase.tsx new file: src/components/common/base/InputBase.tsx new file: src/components/common/base/styles.module.scss new file: src/components/common/styles.module.scss new file: src/components/topbar/PlayPauseButton.tsx new file: src/components/topbar/TempoInput.tsx new file: src/components/topbar/Topbar.tsx new file: src/components/topbar/TopbarBase.tsx new file: src/components/topbar/TopbarTimer.tsx new file: src/hooks/redux.ts modified: src/index.tsx deleted: src/reportWebVitals.ts new file: src/state/slices/playPausePlaylistSlice.ts new file: src/state/slices/playlistMetronomeEnabledSlice.ts new file: src/state/slices/playlistRuntimeSlice.ts new file: src/state/slices/playlistTempoSlice.ts modified: src/state/store.ts modified: tsconfig.json

tonyketcham · 2022-04-07T22:30:44Z

backend/src/util/format.rs

+use chrono;
+
+pub fn format_playlist_runtime(start_ms: i64) -> String {
+  let now_ts = chrono::offset::Local::now().timestamp();
+  let dur = now_ts - start_ms;
+
+  let format = || -> String {
+    let m = (dur as f32 / 60_000.).floor() as i64;
+    let s = ((dur - (m * 60_000)) as f32 / 1_000.).floor() as i64;
+    let ms = dur - (m * 60_000) - (s * 1_000);
+    let mbufc: &str = if m < 10 { "0" } else { "" };
+    let sbufc: &str = if s < 10 { "0" } else { "" };
+    let msbufc: &str = if ms < 10 { "0" } else { "" };
+    format!("{sbufc}{m}:{mbufc}{s}:{msbufc}{ms}")
+  };
+
+  format()
+}


in the future we might want to do this kind of UI-specific unit formatting in TypeScript and keep all the data sent from the engine in ms

should be fine for now since there's no interactivity with the playtime as it's purely a computed property based on where the playhead is

src/state/slices/playPausePlaylistSlice.ts

src/state/slices/playlistMetronomeEnabledSlice.ts

src/state/store.ts

tonyketcham · 2022-04-07T22:46:16Z

src/components/topbar/TopbarTimer.tsx

+import { 
+  selectPlaylistPlaying,
+  PlayPausePlaylistState
+} from '../../state/slices/playPausePlaylistSlice'


we could set the baseUrl = "src" in tsconfig to avoid having to do any ../../ action 😉

does this need any vite configuration..? i think with webpack it might have been needed (?)

src/components/common/base/ButtonBase.tsx

…functions to async

nbennett320 · 2022-04-08T00:57:06Z

can we merge 💀

tonyketcham · 2022-04-08T09:27:01Z

Still trying to get Clippy workin in CI... might need to bounce it out to a separate PR. in the meantime run:
cargo clippy && cargo check

tonyketcham · 2022-04-08T09:30:11Z

can we merge 💀

yeah give it one last rinse but I think we've beaten this thing to death and can just follow up w/ more PRs to correct Types, etc.

Document model V0 + UI/Engine Syncing with Redux + Project structuring

tonyketcham added 2 commits April 5, 2022 19:20

init redux

dd61a37

first audio engine design iteration

2acc2f6

tonyketcham added documentation Improvements or additions to documentation help wanted Extra attention is needed DocumentModel labels Apr 6, 2022

Update and rename audioEngine.md to audio-graph.md

dbc5f1d

nbennett320 reviewed Apr 6, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

tonyketcham commented Apr 6, 2022

View reviewed changes

docs/audio-graph.md Show resolved Hide resolved

nbennett320 marked this pull request as ready for review April 7, 2022 21:40

tonyketcham commented Apr 7, 2022

View reviewed changes

src/state/slices/playPausePlaylistSlice.ts Outdated Show resolved Hide resolved

tonyketcham commented Apr 7, 2022

View reviewed changes

src/state/slices/playlistMetronomeEnabledSlice.ts Outdated Show resolved Hide resolved

tonyketcham commented Apr 7, 2022

View reviewed changes

src/state/store.ts Outdated Show resolved Hide resolved

tonyketcham commented Apr 7, 2022

View reviewed changes

src/components/common/base/ButtonBase.tsx Outdated Show resolved Hide resolved

Noah Bennett added 4 commits April 7, 2022 18:49

committing pnpm-lock / fix build pipeline

c6e8c65

consolidating playlist slices to one file, clean up, move then catch …

6e0a8b1

…functions to async

release build optimizations in cargo.toml

01d9114

add script to link assets to target directory in package.json

c582659

nbennett320 changed the title ~~Document model V0~~ Document model V0 + UI/Engine Syncing with Redux + Project structuring Apr 7, 2022

nbennett320 added this to In Progress 🤠 in Roadmap via automation Apr 7, 2022

nbennett320 removed this from In Progress 🤠 in Roadmap Apr 7, 2022

Noah Bennett added 2 commits April 7, 2022 20:10

init resources page

0869b8a

adding resources

fe7a87c

tonyketcham added 4 commits April 8, 2022 03:21

Add linter jobs to CI

1d87a18

add rustfmt

250257b

update cargo meta

7cdc7ba

run formatter

a933109

tonyketcham requested a review from nbennett320 April 8, 2022 09:29

tonyketcham and others added 2 commits April 8, 2022 10:03

set working dir for clippy job

6d0df7e

changing fmt width to 80

bad9a7d

nbennett320 force-pushed the feature/state branch from 66be5b3 to bad9a7d Compare April 8, 2022 14:04

update lockfile

fcf8abc

nbennett320 merged commit 623b7c1 into main Apr 8, 2022

nbennett320 deleted the feature/state branch April 8, 2022 14:10

nbennett320 added a commit that referenced this pull request Jun 24, 2022

Merge pull request #10 from nbennett320/feature/state

166dc52

Document model V0 + UI/Engine Syncing with Redux + Project structuring

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Document model V0 + UI/Engine Syncing with Redux + Project structuring #10

Document model V0 + UI/Engine Syncing with Redux + Project structuring #10

tonyketcham commented Apr 6, 2022 •

edited

tonyketcham Apr 7, 2022

tonyketcham Apr 7, 2022

tonyketcham Apr 7, 2022

nbennett320 Apr 7, 2022

nbennett320 commented Apr 8, 2022

tonyketcham commented Apr 8, 2022

tonyketcham commented Apr 8, 2022

Document model V0 + UI/Engine Syncing with Redux + Project structuring #10

Document model V0 + UI/Engine Syncing with Redux + Project structuring #10

Conversation

tonyketcham commented Apr 6, 2022 • edited

tonyketcham Apr 7, 2022

Choose a reason for hiding this comment

tonyketcham Apr 7, 2022

Choose a reason for hiding this comment

tonyketcham Apr 7, 2022

Choose a reason for hiding this comment

nbennett320 Apr 7, 2022

Choose a reason for hiding this comment

nbennett320 commented Apr 8, 2022

tonyketcham commented Apr 8, 2022

tonyketcham commented Apr 8, 2022

tonyketcham commented Apr 6, 2022 •

edited