Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable all Form submittals on disabled submit button submissions #848

Open
manfromjupyter opened this issue May 15, 2023 · 3 comments
Open
Assignees

Comments

@manfromjupyter
Copy link
Contributor

manfromjupyter commented May 15, 2023

STOP accepting Enter key or Submit button clicks while the button is grayed out.

In the JS require for each method require the button not be disabled.

THEN make sure the disable button for all forms is disabled by default for all creation forms (i.e. not edit or delete confirmation forms)

Status

Form Summary Disable/Enable support status
Admin - Site Warning#Create Bad Design only (and not disabled by default)
Admin - Site Warning#Edit Bad Design only (and not disabled by default)
Admin - Site Warning#Delete Bad Design only (and not disabled by default)
Admin - Import Notebooks Bad Design only (and not disabled by default)
User (NBGallery) Preferences Perfect N/A - always filled out
Change Ownership Perfect DONE (before)
Deprecate Notebook Perfect DONE (before)
Share Notebook with Users Bad Design only (and not disabled by default)
Add Environment Bad Disabled via design only
Edit Environment Bad Disabled vis design only
Propose for Review Bad Design only (but not disabled by default)
Upload Notebook/Upload new Version - first modal Bad Design only (and not disabled by default)
Upload Notebook - second modal Bad Design only (and not disabled by default)
Upload new Notebook Version - second modal Bad Design only (and not disabled by default)
Propose Change Request - first modal Bad Design only (and not disabled by default)
Propose Change Request - second modal Bad Design only (and not disabled by default)
Accept Change Request Bad Design only (and not disabled by default. User needs to accepts terms of service)
Cancel Change Request Perfect N/A - no required fields
Decline Change Request Perfect N/A - no required fields
User Summary search span VERY Bad Broken
Update Revision Summary Perfect N/A - prepopulated and allows submitting empty
Update Friendly Version Label Perfect N/A - prepopulated and allows submitting empty
Make Private/Make Public Perfect N/A - don't require checking they agree
All Confirmation dialogs Perfect N/A - don't require checking they agree
Search Filtering Very Bad Not ever disabled and issues only caught via back end
Create Group Bad Design only (and not disabled by default)
Edit Group Good N/A - already filled out. Disabled by design only though if any required fields are cleared

Low Priority Probably

Form Summary Disable/Enable support status
New Account Very Bad None - only caught by back end
Edit Account Very Bad None - only caught by back end
Forgot Password Very Bad None - only caught by back end
Change Password Very Bad None - only caught by back end
Resend Confirmation Instructions Very Bad None - only caught by back end
Log in Very Bad None - only caught by back end
Resend Unlock Instructions Very Bad None - only caught by back end
@manfromjupyter
Copy link
Contributor Author

Relates to #639 and readdresses #812 better

TODO as of #851

  1. Get all forms to disable the submit button by default if any required fields are not filled out.
  2. Get all forms ideally to follow disabled="true"/disabled="disabled not just tack on class"disabled" because the latter is purely cosmetic.
  3. Ensure submit buttons are disabled="true"/disabled="disabled for all forms WHILE form is processing/submitting so as to not allow any multiple-submittals.
  4. Full audit that all forms needing required="required" get them

Status as of #851

Form Summary Disable/Enable support status
Admin - Site Warning#Create Good (now) Design only (but now disabled by default with this PR)
Admin - Site Warning#Edit Good (now) N/A - will be all filled out already by default, just is disabled upon removing fields by Design only.
Admin - Site Warning#Delete Perfect (now) DONE - always able to be clicked after site warning has been created. Hidden on new site warnings (now)
Admin - Site Warning#Clear (NEW) Perfect (new) DONE - always able to be clicked on new site warning.
Admin - Import Notebooks Bad Design only (and not disabled by default)
User (NBGallery) Preferences Perfect N/A - always filled out
Change Ownership Perfect DONE (before)
Deprecate Notebook Perfect DONE (before)
Share Notebook with Users Perfect (now) DONE (with this PR)
Add Environment Bad Disabled via design only
Edit Environment Bad Disabled vis design only
Propose for Review Bad Design only (but not disabled by default)
Upload Notebook/Upload new Version - first modal Bad Design only (and not disabled by default)
Upload Notebook - second modal Bad Design only (and not disabled by default)
Upload new Notebook Version - second modal Bad Design only (and not disabled by default)
Propose Change Request - first modal Bad Design only (and not disabled by default)
Propose Change Request - second modal Bad Design only (and not disabled by default)
Accept Change Request Bad Design only (and not disabled by default. User needs to accepts terms of service)
Cancel Change Request Perfect N/A - no required fields
Decline Change Request Perfect N/A - no required fields
User Summary search span VERY Bad Broken
Update Revision Summary Perfect N/A - prepopulated and allows submitting empty
Update Friendly Version Label Perfect N/A - prepopulated and allows submitting empty
Make Private/Make Public Perfect N/A - don't require checking they agree
All Confirmation dialogs Perfect N/A - don't require checking they agree
Search Filtering Very Bad Not ever disabled and issues only caught via back end
Create Group Bad Design only (and not disabled by default)
Edit Group Good N/A - already filled out. Disabled by design only though if any required fields are cleared

Low Priority Probably

Form Summary Disable/Enable support status
New Account Very Bad None - only caught by back end
Edit Account Very Bad None - only caught by back end
Forgot Password Very Bad None - only caught by back end
Change Password Very Bad None - only caught by back end
Resend Confirmation Instructions Very Bad None - only caught by back end
Log in Very Bad None - only caught by back end
Resend Unlock Instructions Very Bad None - only caught by back end

@mcrutch
Copy link
Contributor

mcrutch commented Sep 8, 2023

Propose for review, create group, edit group, external reources all finished in my merge request...still working on more

@mcrutch
Copy link
Contributor

mcrutch commented Sep 8, 2023

admin warning now fully disables, will update this list with changes I am making

Form Summary Disable/Enable support status
Admin - Site Warning#Create Perfect (now) Done
Admin - Site Warning#Edit Perfect (now) Done
Admin - Site Warning#Delete Perfect Done
Admin - Site Warning#Clear Perfect Done
Admin - Import Notebooks Perfect Done
User (NBGallery) Preferences Perfect N/A - always filled out
Change Ownership Perfect Done
Deprecate Notebook Perfect DONE (before)
Share Notebook with Users Perfect DONE (with this PR)
Add Environment Perfect (now)
Edit Environment Perfect (now)
Propose for Review Perfect (now) Done
Upload Notebook/Upload new Version - first modal Perfect (now)
Upload Notebook - second modal Perfect (now)
Upload new Notebook Version - second modal Perfect (now)
Propose Change Request - first modal Perfect (now) Design only (and not disabled by default)
Propose Change Request - second modal Perfect (now) Design only (and not disabled by default)
Accept Change Request Perfect (now) Design only (and not disabled by default. User needs to accepts terms of service)
Cancel Change Request Perfect N/A - no required fields
Decline Change Request Perfect N/A - no required fields
User Summary search span Perfect (now)
Update Revision Summary Perfect N/A - prepopulated and allows submitting empty
Update Friendly Version Label Perfect N/A - prepopulated and allows submitting empty
Make Private/Make Public Perfect N/A - don't require checking they agree
All Confirmation dialogs Perfect N/A - don't require checking they agree
Search Filtering Very Bad Not ever disabled and issues only caught via back end
Create Group Perfect (now)
Edit Group Perfect (now)

Low Priority Probably

Form Summary Disable/Enable support status
New Account Very Bad None - only caught by back end
Edit Account Very Bad None - only caught by back end
Forgot Password Very Bad None - only caught by back end
Change Password Very Bad None - only caught by back end
Resend Confirmation Instructions Very Bad None - only caught by back end
Log in Very Bad None - only caught by back end
Resend Unlock Instructions Very Bad None - only caught by back end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants