Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

footer-refs-validity false positive #158

Open
knocte opened this issue Jan 29, 2024 · 0 comments
Open

footer-refs-validity false positive #158

knocte opened this issue Jan 29, 2024 · 0 comments

Comments

@knocte
Copy link
Member

knocte commented Jan 29, 2024

+ npx commitlint --from HEAD~1 --to HEAD --verbose
⧗   input: scripts/checkCommits1by1: fix IndexOutOfRangeEx

We tried to make this script support for legit absence
of CI status via [1] but that caused IndexOutOfRangeExs.
This change now makes sure that the commitMsg is extracted
from the 1st API call (which is not dependent on a CI
status being present) so it should fix the problem (the
use of `[0]` hardcoded indexing was a big smell here that
turned out to cause this problem).

[1] 8c00fed7d2[45](https://github.com/knocte/conventions/actions/runs/7692618873/job/20959909590#step:7:46)89d7b70957cc872b1a1e57a76f93
✖   All references in the body must be mentioned in the footer, and vice versa.
For reference, these are the guidelines that include our commit message conventions: https://github.com/nblockchain/conventions/blob/master/docs/WorkflowGuidelines.md [footer-refs-validity]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant