Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory issue? #7

Closed
dscos opened this issue Mar 20, 2020 · 7 comments
Closed

Memory issue? #7

dscos opened this issue Mar 20, 2020 · 7 comments
Labels
working on it Currently working on adding functionality

Comments

@dscos
Copy link

dscos commented Mar 20, 2020 •
edited

PlayStatus is using 1.15 GB of RAM on my machine right now. I have 16GB RAM so it's not a big deal for me, but it seems excessive for a menubar app so I thought I'd bring it to your attention.

Screen Shot 2020-03-20 at 5 12 06 PM
@nbolar
Copy link
Owner

nbolar commented Mar 22, 2020 •
edited

Okay that definitely is concerning. Let me see what the issue is and I'll get back to you.

Edit: Just a quick side note till I find the issue, what happens when you restart the app and then track it using Activity Monitor?

@dscos
Copy link
Author

dscos commented Mar 27, 2020

Sorry, just saw this. Closed the app and relaunched it, it started at 7.5 MB and then jumped to around 11 MB. After about 15 minutes it's at 18.1 MB now. A few times, it seemed to jump up by 3-4 MB when I skipped tracks, but that doesn't seem to be happening. I'll continue to check it and update.

@dscos
Copy link
Author

dscos commented Mar 27, 2020

After about an hour it's at 50.4 MB

@nbolar
Copy link
Owner

nbolar commented Mar 27, 2020

I've been trying to figure out what's causing this for the past few days and it looks like the scrolling menu bar feature of the app is the culprit i.e. when song names are large and require the scrollable feature, there is a slow but steady increase in memory. On the other hand if I disable the scrolling ability, the memory consumption stays relatively constant and significantly lower. Unfortunately that bit was not coded by me and is a third party open source file that I've incorporated. So as of now, I'm not sure how far I'll be able to optimize it. But I'll keep working on it.

@dscos
Copy link
Author

dscos commented Mar 27, 2020

Personally, I liked the old SpotMenu behavior of not scrolling and just displaying the whole long song title, but I'm probably in the minority on that. Maybe make it a toggleable option with a note that the scrolling functionality eats more memory? Or is there maybe a middle ground where you could make the PlayStatus area wider, thus necessitating scrolling less frequently?

Like I said, I have plenty of memory so it's not a big deal for me personally, and now that I'm aware, I can always restart the app if it gets out of hand.

@nbolar
Copy link
Owner

nbolar commented Mar 27, 2020

You make some good points. I'll consider adding those preferences so that the user can choose what they want, into the next update. It'll probably take some time to finalize the next version just so that I make sure that the different options don't eat up too much memory.

@nbolar nbolar added the working on it Currently working on adding functionality label Apr 10, 2020
@nbolar
Copy link
Owner

nbolar commented Apr 26, 2020

Hey @dscos the new update is now live. Hopefully this fixes the memory usage bug. Also hope the Spotify bug gets fixed soon.

@nbolar nbolar closed this as completed Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
working on it Currently working on adding functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dscos @nbolar