Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion error when checking if a MinMaxHeap is a MinMaxHeap inside the deletion operation #62

Closed
nbro opened this issue Mar 14, 2017 · 1 comment
Labels
bug An error in the source code.

Comments

@nbro
Copy link
Owner

nbro commented Mar 14, 2017

When I was running all tests locally, using the script ./run_tests.sh, at a certain point, an assertion (i.e. assert is_min_max_heap(self)) in the deletion operation was not satisfied. This only occurred locally and when I run all tests, apparently.

In general, there was some strange behavior going on.

Verify that the algorithm for deleting an element from a MinMaxHeap (and also MaxHeap and MinHeap) really work, but thinking about all possible cases!!!

@nbro nbro added bug An error in the source code. possible-bug and removed bug An error in the source code. possible-bug labels Mar 14, 2017
@nbro nbro changed the title Possible bug in deletion operation of the MinMaxHeap Bug in deletion operation of the MinMaxHeap Mar 14, 2017
@nbro nbro changed the title Bug in deletion operation of the MinMaxHeap Assertion error when checking if a MinMaxHeap is a MinMaxHeap inside the deletion operation Mar 14, 2017
@nbro
Copy link
Owner Author

nbro commented Sep 28, 2017

The bug was apparently in the function is_min_max_heap (and not in the delete method of MinMaxHeap).

@nbro nbro closed this as completed Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the source code.
Projects
None yet
Development

No branches or pull requests

1 participant