Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue 36 #41

Merged
merged 2 commits into from
Jan 22, 2017
Merged

Fixed issue 36 #41

merged 2 commits into from
Jan 22, 2017

Conversation

nbro
Copy link
Owner

@nbro nbro commented Jan 22, 2017

Fixed by checking input keys as follows:

  1. Raise TypeError if the key is not an instance of str
  2. Raise a ValueError if the key is empty
  3. Raise a TypeError if value is none

@nbro
Fixed issue 36
f5c6563 
Fixed by checking input keys as follows:

1. Raise TypeError if the key is not an instance of str
2. Raise a ValueError if the key is empty
3. Raise a TypeError if value is none
@coveralls
Copy link

coveralls commented Jan 22, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 92.903% when pulling f5c6563 on iss36 into 85d270a on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.903% when pulling b0866d3 on iss36 into 85d270a on master.

1 similar comment
@coveralls
Copy link

coveralls commented Jan 22, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 92.903% when pulling b0866d3 on iss36 into 85d270a on master.

@nbro nbro merged commit e9c31ef into master Jan 22, 2017
@nbro nbro deleted the iss36 branch January 22, 2017 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nbro @coveralls