-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CTT is not producing result similar to UPP #45
Comments
After looking at this more closely, the algorithm works by searching for an optical depth greater than 1.0 for each vertical column in the domain. If the search finds no optical depth (clear sky), then the surface temperature is returned for that column. I think we can simply add a flag to indicate that the user wants missing/fill values to be returned for these areas instead of surface temperature, but keep the default the same so that backwards compatibility is retained. The line of code that will need to be modified is:
Change this to insert a missing value, then later check if it's missing and skip the interpolation for temperature. |
The OpenMP directive issue will be fixed in 1.1.2. The option to add fill values for no-cloud areas will be released later. |
There is an indexing bug here:
There is nothing preventing k from being 1, which is causing Windows to crash, and this is a ticking time bomb for Linux and Mac. |
Also, the computation is not correctly integrating from top to bottom when using WRF files that do not contain cloud ice mixing ratio. |
The fixes include an out of bounds error and the optical depth calculation was incorrect when cloud ice mixing ratio was missing. Users can now also specify if they want missing cloud areas to use fill values instead of surface temperature. Users can also specify the optical depth required to trigger the calculation. Also, support added for calculating cape_2d with a single vertical column. Fixes #45. Fixes #46.
This issue was reported on wrfpython-talk:
https://groups.google.com/a/ucar.edu/forum/#!topic/wrfpython-talk/5D3JgHb0lDI
The CTT algorithm doesn't match UPP very well, and the UPP result looks good.
At first glance, a few issues were found:
The text was updated successfully, but these errors were encountered: