Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate to valid URLs from any page #33

Closed
meera-gd opened this issue Jun 13, 2017 · 1 comment
Closed

Navigate to valid URLs from any page #33

meera-gd opened this issue Jun 13, 2017 · 1 comment
Assignees

Comments

@meera-gd
Copy link
Contributor

Currently, the password reset links and concept map links are only accessible when navigating to the link from a new browser tab (or from a different website). This is because these URLs are only processed in the DesktopUI::init() method. The user should be able to navigate to these pages even if they are already in the application.

@meera-gd meera-gd self-assigned this Jun 13, 2017
meera-gd added a commit that referenced this issue Jun 15, 2017
@meera-gd
Copy link
Contributor Author

meera-gd commented Jun 15, 2017

There seems to be an issue with how Vaadin handles the '+' symbol in URI fragments. In DesktopUI.init() , Page.getUriFragment() correctly decodes the symbol as a plus. But in listeners attached to Navigator, Page.getUriFragment() incorrectly decodes the symbol as a space.

Because of this behaviour, the application is effectively unable to distinguish pluses from spaces in URLs. To work around this problem, URLs given to users (like the concept map URLs) should have '+' symbols percent-encoded as %2B. AuthenticationManager.makeSafeURL(String fragment) does this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant