Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow request module override #16

Merged
merged 5 commits into from Aug 15, 2013
Merged

Conversation

cpsubrian
Copy link
Collaborator

Relating to #15

These changes accomplish a few important goals:

  • Allow apps to override the request handler.
  • Pull request parsing out of the api modules.
  • Options passed to the request handler more closely conform to node core's url spec.

This allows 'userland' add-ons such as memcached protocol support.

I've taken care that all tests pass with NO changes to the tests themselves (no API changes).

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling aab916f on TerraEclipse:refactor into 2bf522b on ncb000gt:master.

@brozeph
Copy link
Collaborator

brozeph commented Aug 15, 2013

This is looking very clean! Merging, rev'ing and publishing...

brozeph added a commit that referenced this pull request Aug 15, 2013
Allow request module override
@brozeph brozeph merged commit 6a200c4 into ncb000gt:master Aug 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants