Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Revert small change.

Signed-off-by: Nick Campbell <>
  • Loading branch information...
commit f5e661816c6dd8b9a5a2593dc7454c1a0ba1d3be 1 parent d413fe0
Nick Campbell authored
Showing with 1 addition and 1 deletion.
  1. +1 −1  src/
2  src/
@@ -361,7 +361,7 @@ bool CompareStrings(const char* s1, const char* s2) {
int s2_len = strlen(s2);
if (s1_len != s2_len) {
- return false;
+ eq = false;
const int max_len = (s2_len < s1_len) ? s1_len : s2_len;

3 comments on commit f5e6618

Roman Shtylman

Make sure to mark that bad version as deprecated on npm. Or possibly unpublish it.

Nick Campbell

Already unpublished and republished with the appropriate code. Although, I guess I probably should have bumped the version in case anyone nabbed it in between... =\

Kip Gebhardt

I would suggest a version # bump. We got caught out by the duplicate version number.

Please sign in to comment.
Something went wrong with that request. Please try again.