Skip to content

Commit

Permalink
Revert small change.
Browse files Browse the repository at this point in the history
Signed-off-by: Nick Campbell <nicholas.j.campbell@gmail.com>
  • Loading branch information
ncb000gt committed Mar 12, 2013
1 parent d413fe0 commit f5e6618
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/bcrypt_node.cc
Expand Up @@ -361,7 +361,7 @@ bool CompareStrings(const char* s1, const char* s2) {
int s2_len = strlen(s2);

if (s1_len != s2_len) {
return false;
eq = false;
}

const int max_len = (s2_len < s1_len) ? s1_len : s2_len;
Expand Down

3 comments on commit f5e6618

@defunctzombie
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to mark that bad version as deprecated on npm. Or possibly unpublish it.

@ncb000gt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already unpublished and republished with the appropriate code. Although, I guess I probably should have bumped the version in case anyone nabbed it in between... =\

@rv-kip
Copy link

@rv-kip rv-kip commented on f5e6618 Apr 23, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest a version # bump. We got caught out by the duplicate version number.

Please sign in to comment.