Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM Gulp does not deliver ready state ICn3D #43

Closed
th3linja opened this issue Sep 14, 2021 · 2 comments
Closed

NPM Gulp does not deliver ready state ICn3D #43

th3linja opened this issue Sep 14, 2021 · 2 comments

Comments

@th3linja
Copy link
Collaborator

When downloading and compiling the project from scratch, NPM Gulp does not produce a product ready for use. The following three files are afflicted or affecting the overall product in use:

  • icn3d_x.x.x.min.js (not compiled correctly - text comparison tested)
  • three_0.128.0.min.js (not compiled correctly - text comparison tested))
  • ui-bg_gloss-wave_55_5c9ccc_500x100.png (file not found)

image
image
image
image

@jiywang3
Copy link
Contributor

The icn3d npm package at https://www.npmjs.com/package/icn3d is used to generate Node.js only. The graphics rendering part was turned off for Node.js scripts.

All web usage should use the zip file mentioned at the beginning of iCn3D GitHub page: " Complete package of iCn3D including Three.js and jQuery can be downloaded from https://www.ncbi.nlm.nih.gov/Structure/icn3d/icn3d-3.4.3.zip". The Three.js library was slightly modified to make impostor work as before.

@jiywang3
Copy link
Contributor

As shown in the gulp.js file, some extra parameters were set specifically for Node.js in the file https://github.com/ncbi/icn3d/blob/master/src/thirdparty/defineWindow.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants