Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container Support AWS #1491

Open
johnkoehn opened this issue Jan 3, 2023 · 10 comments
Open

Container Support AWS #1491

johnkoehn opened this issue Jan 3, 2023 · 10 comments
Labels
enhancement New feature or request

Comments

@johnkoehn
Copy link

Is your feature request related to a problem? Please describe.

When running scoutsuite for aws, the report shows a containers tab. However no information ever populates it, even in accounts using ECS, EKS and ECR.

Describe the solution you'd like

To have security rules ran against those services.

Describe alternatives you've considered

N/A

Additional context

N/A

@johnkoehn johnkoehn added the enhancement New feature or request label Jan 3, 2023
@kedar1704
Copy link

How can I add ECS, EKS service in this project?

@CaseyLabs
Copy link

Just ran into this issue as well. We use AWS Fargate, and yet Scout's dashboard for Containers/ECS shows up empty.

Is there a setting we are missing here? cc @fernando-gallego

@liyun-li
Copy link
Collaborator

Hi folks, I am the guy who added a Kubernetes provider to Scout Suite. Can you let us know which branch you are using? Bug fixes might have already been introduced into the develop branch.

@krupalb
Copy link

krupalb commented Apr 12, 2023

it's not working from Develop branch either....?

@liyun-li
Copy link
Collaborator

it's not working from Develop branch either....?

Can you perhaps share screenshots?

@ashu-pattanayak
Copy link

@liyun-li

I tried from the develop branch and below is the error.

1
2

@liyun-li
Copy link
Collaborator

Ah that's probably because the open source version doesn't have any findings for EKS...Feel free to pull request!

@michaels0184
Copy link

Has this been updated? I am also unable to pull any information on ECS when using both the 'master' or 'develop' branches.
image

@kedar1704
Copy link

kedar1704 commented Nov 26, 2023

Hi folks,I am the guy who added a AWS Container services to Scout Suite. Please check this repo https://github.com/kedar1704/ScoutSuite.git. Your feedback on the introduced features, code changes, and the overall impact on ScoutSuite's capabilities in AWS environments is highly appreciated. Feel free to reach out with any questions or concerns.

@crahan
Copy link

crahan commented Jan 12, 2024

I was confused about this initially as well, but support for a number of AWS services is considered proprietary in ScoutSuite, as shown in:

# Try to import proprietary services
try:
from ScoutSuite.providers.aws.resources.private_cognito.base import Cognito
except ImportError:
pass
try:
from ScoutSuite.providers.aws.resources.private_docdb.base import DocDB
except ImportError:
pass
try:
from ScoutSuite.providers.aws.resources.private_ecr.base import ECR
except ImportError:
pass
try:
from ScoutSuite.providers.aws.resources.private_ecs.base import ECS
except ImportError:
pass
try:
from ScoutSuite.providers.aws.resources.private_eks.base import EKS
except ImportError:
pass
try:
from ScoutSuite.providers.aws.resources.private_guardduty.base import GuardDuty
except ImportError:
pass
try:
from ScoutSuite.providers.aws.resources.private_ssm.base import SSM
except ImportError:
pass

As a result, support for things like ECS, EKS and ECR (and Cognito, DocDB, GuardDuty, and SSM) isn't included in the Open Source ScoutSuite version and thus no resource information for these services will be retrieved or rules run.

The pull request created by @kedar1704 adds the missing capabilities for the AWS ECS, EKS and ECR services. It would be awesome if someone could review this PR and merge, if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants