Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs With Only Base Replacements Don't Fire #23

Closed
jacobheath opened this issue Jun 19, 2018 · 3 comments
Closed

Tabs With Only Base Replacements Don't Fire #23

jacobheath opened this issue Jun 19, 2018 · 3 comments

Comments

@jacobheath
Copy link

Me again,
Looks like when I have a bunch of base replacements, but no regular replacements, AutoRepeater doesn't capture requests properly. I've attached two configuration files that show this:

Working:

working.zip

Not Working:

not-working.zip

The scenario I am trying to get working is have an individual tab for each user session. Each tab needed several base replacements so that I could modify their CSRF token in the header and the numerous cookies the application uses to identity the user.

@justinmoore
Copy link
Collaborator

Hey,

I noticed this behavior earlier today. The reason it's like this is because originally all of the Base Replacements would get bundled up into one one request and get sent and then that request would get copied and each Replacement would get applied to it separately. This was causing extra outbound requests and was confusing. I changed it to have Base Replacements not send a request but I agree that the behavior isn't correct because it doesn't allow AutoRepeater to handle situations like the one you described.

I'll change the behavior to send the outbound request if a tab has Base Replacements defined but not Replacements to fix this.

Also, I think i've fixed the threading issue, i'll push both these fixes together in a few minutes.

Thanks,
Justin

@justinmoore
Copy link
Collaborator

This should be fixed in the newest JAR now, I'll wait for confirmation before i close this.

@justinmoore
Copy link
Collaborator

I'll close this now. If there's any more issues feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants