Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After run the program doesn't exit, "finished" button ghosted #13

Open
alanmcg opened this issue Oct 15, 2018 · 3 comments
Open

After run the program doesn't exit, "finished" button ghosted #13

alanmcg opened this issue Oct 15, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@alanmcg
Copy link

alanmcg commented Oct 15, 2018

Just finished my first run, 6273 of 6273 checks completed but the program doesn't exit and the "Finished" button on the tk app is ghosted out so can't be clicked.

Terminal output ended at WARNING:aws_inventory.invoker:No work to be done. with no further output.

Ctrl c'd and it exited without writing any files

EDIT: it did write the json output

@bitsandsalsa
Copy link
Collaborator

Regarding the "Finished" button. It should begin as "Start", then change (to the state you are referring to) after completion of all work. You can close this like a regular window. Using your mouse on the window title bar or a keyboard combination while focused on the window (e.g., alt+f4).

The warning could be clearer. It is saying that for a service in a region, there were no operations to call. This can happen if your filter configuration is too restrictive. What is the commandline string you used to run the tool? Did you modify the default blacklist file? The warning might be repeated because of the way the code uses many worker threads to break up all of the work.

Did your JSON file have anything in the "responses" key? This would show up in the browser GUI in the "Inventory" section after having loaded the JSON file.

@alanmcg
Copy link
Author

alanmcg commented Oct 17, 2018

Thanks for your quick response! Really like this tool so far, it's a very nice solution to getting an overview of an aws infrastructure.

  1. it wasn't super clear that i could just close the window, making the finished button clickable would be a good user experience improvement.
  2. I used the command without additional parameters other than setting the profile, no changes were made to the blacklist file. Not certain that the account has all the read accesses it requires (still relatively new to AWS).
  3. the JSON output had data in some fields, such as IAM users, some did not have complete data such as the instances in EC2, but again I think that may be to access rights on my user.

@bitsandsalsa bitsandsalsa added the enhancement New feature or request label Oct 24, 2018
@ncc-erik-steringer
Copy link
Collaborator

Cleaning out issues. It looks like this still needs some work, here are some goals I'm setting:

  • Automatically close the GUI at the end of the gathering
  • Automatically open the report at the end of the gathering

@ncc-erik-steringer ncc-erik-steringer added this to TODO in Path to v1.0.0 via automation Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

3 participants