Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for installation instructions #120

Closed
dmarcoux opened this issue Jan 30, 2023 · 1 comment · Fixed by #121
Closed

Suggestion for installation instructions #120

dmarcoux opened this issue Jan 30, 2023 · 1 comment · Fixed by #121

Comments

@dmarcoux
Copy link
Contributor

sobelow is often running in continuous integration pipelines and when it does, it will more often than not be in the test environment. On top of this, sobelow doesn't have to be started as a runtime application, so runtime: false should also be added to the installation instructions. This is what I suggest for the README:

def deps do
  [
    {:sobelow, "~> 0.11", only: [:dev, :test], runtime: false}
  ]
end

I am happy to send a PR if you agree with the suggestion.

@houllette
Copy link
Collaborator

Great suggestion, @dmarcoux - I would happily welcome a PR if you made one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants