Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracy being enabled causes some websites to incorrectly redirect #118

Closed
MichaelBlakeOIT opened this issue Nov 5, 2019 · 5 comments
Closed

Comments

@MichaelBlakeOIT
Copy link

When going through shopify at https://anystorehere.myshopify.com, I get redirected to https://anystorehere.myshopify.comhttps://anystorehere.myshopify.com. This does not happen when Tracy is disabled. I have tried this in both Chrome and Firefox.

@jacobheath
Copy link
Collaborator

Hmm, do you have an example shopify store I can try?

@MichaelBlakeOIT
Copy link
Author

@jacobheath I can't find any examples that don't require being logged in, but if you're logged into a shop, and visit https://whateveryourshopnameis.myshopify.com/admin/products you will be redirected to https://whateveryourshopnameis.myshopify.com/admin/productshttps://whateveryourshopnameis.myshopify.com/admin/products

I'll continue looking around for an area that doesn't require logging in or another site that has this behavior.

@jacobheath
Copy link
Collaborator

I created a free trial and was able to reproduce the issue. Diving into it now.

@jacobheath
Copy link
Collaborator

I think I figured it out. I was keeping when XHRs were being made in the current this context. Turns out, I wasn't using a unique enough variable name because the code on Shopify was also using that same variable name to set the window.location. Luckily, I don't need this state anymore. I am pushing a commit that removes the code. In a few minutes, update your version of Tracy and give it a shot and let me know if it works.

@MichaelBlakeOIT
Copy link
Author

Looks good! Thanks for the quick patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants