Data races

[gg-gg-gg-gg]

There's a few data races on the request object in proxy.go, going to tackle removing those and refactoring that file. Assign to me please @jacobheath

nati:~/golang/src/github.com/nccgroup/tracy/proxy$ go test -race -timeout 30s github.com/nccgroup/tracy/proxy -run ^TestFullProxy$
==================
WARNING: DATA RACE
Write at 0x00c4204f4790 by goroutine 83:
  github.com/nccgroup/tracy/proxy.handleConnection()
      /Users/nati/golang/src/github.com/nccgroup/tracy/proxy/proxy.go:157 +0x1447

Previous read at 0x00c4204f4790 by goroutine 20:
  github.com/nccgroup/tracy/proxy.handleConnection.func1()
      /Users/nati/golang/src/github.com/nccgroup/tracy/proxy/proxy.go:122 +0x53

Goroutine 83 (running) created at:
  github.com/nccgroup/tracy/proxy.(*Proxy).Accept()
      /Users/nati/golang/src/github.com/nccgroup/tracy/proxy/proxy.go:35 +0x128

Goroutine 20 (running) created at:
  github.com/nccgroup/tracy/proxy.handleConnection()
      /Users/nati/golang/src/github.com/nccgroup/tracy/proxy/proxy.go:121 +0x13ea
==================
--- FAIL: TestFullProxy (0.00s)
	testing.go:730: race detected during execution of test
FAIL
FAIL	github.com/nccgroup/tracy/proxy	0.087s

[gg-gg-gg-gg]

nati:~/golang/src/github.com/nccgroup/tracy$ git checkout nati/waitgroup-and-mutexes
Switched to branch 'nati/waitgroup-and-mutexes'
nati:~/golang/src/github.com/nccgroup/tracy$ /usr/local/go/bin/go test -race -benchmem -run=^$ github.com/nccgroup/tracy/proxy -bench ^BenchmarkFullProxy$
goos: darwin
goarch: amd64
pkg: github.com/nccgroup/tracy/proxy
BenchmarkFullProxy-4         500           6411523 ns/op          481362 B/op       5700 allocs/op
PASS
ok      github.com/nccgroup/tracy/proxy 4.880s

[gg-gg-gg-gg]

🎉

[gg-gg-gg-gg]

Little slower with the locking but once I do some memory optimizations it'll be good.

[heathj]

This seems to be fixed now:

% go test -race -timeout 30s github.com/nccgroup/tracy/proxy -run ^TestFullProxy$
ok  	github.com/nccgroup/tracy/proxy	2.034s