Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sktime version matching #1262

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Update sktime version matching #1262

merged 4 commits into from
Mar 5, 2024

Conversation

DRMPN
Copy link
Collaborator

@DRMPN DRMPN commented Mar 1, 2024

Support Python 3.12 installation

This is a 🙋 feature or enhancement.

Summary

Update requirements to support Python 3.12 installation.

  • Change sktime version matching from == to >= .

Context

Resolves #1260

Support Python 3.12 installation
@DRMPN DRMPN added the enhancement New feature or request label Mar 1, 2024
@DRMPN DRMPN requested review from nicl-nno and valer1435 March 1, 2024 18:17
@DRMPN DRMPN self-assigned this Mar 1, 2024
@DRMPN DRMPN linked an issue Mar 1, 2024 that may be closed by this pull request
Copy link

docu-mentor bot commented Mar 1, 2024

👋 Hi, I'm @docu-mentor, an LLM-powered GitHub app
powered by Anyscale Endpoints
that gives you actionable feedback on your writing.

Simply create a new comment in this PR that says:

@docu-mentor run

and I will start my analysis. I only look at what you changed
in this PR. If you only want me to look at specific files or folders,
you can specify them like this:

@docu-mentor run doc/ README.md

In this example, I'll have a look at all files contained in the "doc/"
folder and the file "README.md". All good? Let's get started!

Copy link
Contributor

github-actions bot commented Mar 1, 2024

All PEP8 errors has been fixed, thanks ❤️

Comment last updated at

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.85%. Comparing base (fd21c70) to head (afe19d6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1262   +/-   ##
=======================================
  Coverage   79.85%   79.85%           
=======================================
  Files         146      146           
  Lines       10030    10030           
=======================================
  Hits         8009     8009           
  Misses       2021     2021           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicl-nno
Copy link
Collaborator

nicl-nno commented Mar 2, 2024

Так вроде тесты не проходят. Возможно, надо под разные версии питона разный sktime?

@DRMPN
Copy link
Collaborator Author

DRMPN commented Mar 2, 2024

С этими изменениями sktime [pip] будет устанавливаться и запускаться на 3.8 - 3.12 👍.

Однако на 3.11 и 3.12 giotto-tda [pip] не поддерживается и ругается:

ERROR: Could not find a version that satisfies the requirement giotto-tda==0.6.0 (from fedot) (from versions: 0.1.4)
ERROR: No matching distribution found for giotto-tda==0.6.0
Error: Process completed with exit code 1.

Проверил установку здесь и с измененями из PR #1261 здесь.

@DRMPN DRMPN merged commit 9bdb42e into master Mar 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.12 support
3 participants