Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data file and log file still use addressbook #3

Open
ncduy0303 opened this issue Nov 17, 2023 · 1 comment
Open

Data file and log file still use addressbook #3

ncduy0303 opened this issue Nov 17, 2023 · 1 comment
Labels
severity.VeryLow status.Done type.FunctionalityBug

Comments

@ncduy0303
Copy link
Owner

ncduy0303 commented Nov 17, 2023 •
edited
Loading

Description

Names of the additional files for using the application

Expected behaviour

Expecting it to be similar to your application name.

Actual behaviour

Still refers to AB3 name

Reason for severity

Comestic issue.
@nus-pe-bot
Copy link

nus-pe-bot commented Nov 20, 2023 •
edited by ncduy0303
Loading

Team's Response

It is valid to name our json files as addressbook, as the StudentConnect app is an addressbook itself. It also does not affect the app in any way.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: [replace this with your explanation]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity.VeryLow status.Done type.FunctionalityBug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ncduy0303 @nus-pe-bot