Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit and delete person by email is too hard to type #4

Open
ncduy0303 opened this issue Nov 17, 2023 · 1 comment
Open

Edit and delete person by email is too hard to type #4

ncduy0303 opened this issue Nov 17, 2023 · 1 comment

Comments

@ncduy0303
Copy link
Owner

ncduy0303 commented Nov 17, 2023

Description

Try to edit and delete students in the application takes a lot of time

Reason for severity

It is a common use case and it cause slight inconvenience for a CLI user (especially when editting). Users need to type out the entire email of the student (why not skip the domain if everyone's email ends with @u.nus.edu)?

@soc-se-bot
Copy link

soc-se-bot commented Nov 20, 2023

Team's Response

We reject this bug report as this is a suggestion. Most users would also not have a problem typing the domain name as the product is designed for fast-typists.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: As mentioned in the course website, the application is expected to be optimised for CLI usage, so unnecessary long and complicated command format is supposed to be a feature flaw.

LongCommandFeatureFlaw.png

I believe the command is unneccessary long since the application imposes a very strict validation on email formats in the first place (the domain must be @u.nus.edu and nothing else). This means that all emails stored in this application must have the same domain, so it becomes cumbersome yet redundant for users to type the full EMAIL (an additional of 10 keystrokes for the domain with special character @, when the shorter local-format should be sufficient) for the commands below:

  • Adding a Student: add n/NAME m/MAJOR y/YEAR e/EMAIL d/DESCRIPTION [t/TUTORIALS]... [sm/SOCIALMEDIA]... nt/NATIONALITY g/GENDER
  • Editting a Student: edit EMAIL [n/NAME] [m/MAJOR] [y/YEAR] [e/EMAIL] [d/DESCRIPTION] [t/TUTORIALS]... [sm/SOCIALMEDIA]... [nt/NATIONALITY] [g/GENDER]
  • Deleting a Student: delete EMAIL
  • Joining a Group: join e/EMAIL gr/GROUP_NUMBER
  • Leaving a Specific Group: leave e/EMAIL gr/GROUP_NUMBER

EmailFormat.png

After reconsidering the issue of unnecessary long email format on the usage of the application, I think it causes more of occasional inconvenience for some users rather than minor inconvenience in rare situations because the 5 commands affected are used quite frequently for users when they are trying to allocate students to group (meaning they need to use join, leave and even edit to change the tutorial slot quite often).

Hence, I would suggest raising the severity of this FeatureFlaw from Low to Medium


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants