Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints for all functions #37

Closed
tennlee opened this issue Aug 23, 2023 · 2 comments
Closed

Add type hints for all functions #37

tennlee opened this issue Aug 23, 2023 · 2 comments
Assignees
@aidanjgriffiths
Milestone
Wishlist

Comments

@tennlee
Copy link
Collaborator

tennlee commented Aug 23, 2023

Add type hints for all functions (not just the public functions)
@tennlee tennlee added this to the Wishlist milestone Aug 30, 2023
@aidanjgriffiths
Copy link
Collaborator

@tennlee, I'm taking this issue.

@aidanjgriffiths aidanjgriffiths self-assigned this Oct 15, 2023
@tennlee
Copy link
Collaborator Author

tennlee commented Apr 16, 2024

Type hints are now used in most if not all functions. I don't think it's necessary to do a complete re-audit at this stage, but through the code review process of new MRs.

@tennlee tennlee closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aidanjgriffiths aidanjgriffiths

Labels
None yet
Projects
None yet
Milestone
Wishlist
Development

No branches or pull requests
2 participants
@aidanjgriffiths @tennlee