Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: use vim highlight instead of unicode replacement for highlight #1

Closed
clason opened this issue Jul 14, 2018 · 3 comments
Closed
Labels
wontfix This will not be worked on

Comments

@clason
Copy link

clason commented Jul 14, 2018

Depending on the terminal font, the unicode math symbols look very different from the normal text. Would it be possible to use neovim's builtin highlight attributes instead (or in addition)?

From :h ui-event-highlight_set:

["highlight_set", attrs]
	Set the attributes that the next text put on the grid will have.
	`attrs` is a dict with the keys below. Any absent key is reset
	to its default value. Color defaults are set by the `update_fg` etc
	updates. All boolean keys default to false.

	`foreground`:	foreground color.
	`background`:	backround color.
	`special`:	color to use for underline and undercurl, when present.
	`reverse`:	reverse video. Foreground and background colors are
			switched.
	`italic`:	italic text.
	`bold`:		bold text.
	`underline`:	underlined text. The line has `special` color.
	`undercurl`:	undercurled text. The curl has `special` color.

Either bold, italic, or swapping fore- and background will probably look nicer.

@roxma
Copy link
Member

roxma commented Jul 14, 2018

Would it be possible to use neovim's builtin highlight attributes instead (or in addition)?

I think this is impossible.

The completion is triggered by :help complete() call. The documentation of complete says nothing about highlight.

This plugin is just an experimental hack. For real completion highlight support, we'll need neovim implementing this feature.

// cc @justinmk

@roxma roxma added the wontfix This will not be worked on label Jul 14, 2018
@clason
Copy link
Author

clason commented Jul 14, 2018

Makes sense; I also realized too late that the replacement is done on the python side, not the vim side. Sorry for the noise!

@clason clason closed this as completed Jul 14, 2018
@docwhat
Copy link

docwhat commented Jul 25, 2018

I submitted a Neovim issue: neovim/neovim/issues/8780

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants