Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Diffs for 0.52.0 #25

Closed
EyMaddis opened this issue Jan 9, 2018 · 5 comments
Closed

Create Diffs for 0.52.0 #25

EyMaddis opened this issue Jan 9, 2018 · 5 comments

Comments

@EyMaddis
Copy link

EyMaddis commented Jan 9, 2018

First off: thanks for your dedication and a happy new year!

0.52.0 is out for almost a month and I would love to use your tool again!

@ujwal-setlur
Copy link

So, I am little confused. on react-native's home page, 0.52.0 is still tagged as 0.52-RC. Is it really officially out?

@awinograd
Copy link

Looks like that linked page is behind. The official release is out on github

https://github.com/facebook/react-native/releases/tag/v0.52.0

@dino115
Copy link

dino115 commented Jan 15, 2018

I've forked the repo and added 0.52.0, for now you can use this diff:

dino115/rn-diff@rn-0.51.0...rn-0.52.0

By the way, it is very easy to do it by your own.

  1. fork and clone repo
  2. use the new-version script
    ./new-version.sh rn-0.51.0 0.52.0
  3. click on the compare link generated in the readme
  4. replace the github username in the url

I hope this repo will be maintained for future versions. Thanks for the idea and your great work!

@ryankask
Copy link
Collaborator

I've tried generating a new branch by running a new_version.sh but the diff doesn't look like @dino115's, even after a fresh clone of rn-diff.

I'll try again soon and sorry about the delay.

@ncuillery
Copy link
Owner

I've just pushed the 0.52.0 and 0.52.1 branches. Thanks @dino115 to have brought the update during the delay, sorry for that 🙄

@ryankask that's curious, have you figured out why you had a difference? (no problem from my side)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants