Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double click to rename collection instead leaks 200 MB of memory and does nothing #35

Closed
IBwWG opened this issue Aug 30, 2016 · 9 comments

Comments

@IBwWG
Copy link

IBwWG commented Aug 30, 2016

I'm not sure with what version of coa_tools I could rename still, but with the latest on blender 2.77a, whenever I've tried double-clicking to rename a collection, like the mouseover tooltip says, instead of allowing a rename, my laptop's fans spool up for a couple seconds, blender claims an additional 200 MB of RAM, and nothing else happens. I tried it four times over the last minute, and blender is now sitting on 1.6 GB and will need a restart to continue working much longer (at least, this is how it seems to be on my system. I only have 4 GB to begin with.)

200 MB is also the amount it takes adding a new collection.

@ndee85
Copy link
Owner

ndee85 commented Aug 30, 2016

Hmm.. renaming is strange in general. I'll have a look.

@ndee85
Copy link
Owner

ndee85 commented Aug 30, 2016

I cannot reproduce this on my side, but I have found another bug when keying multiple sprites at once. This could result in not proper action naming. This is fixed now. I don't know if this may be connected.
If it still does not work, please provide a blend file where this happens so I can take a look at it.

@IBwWG
Copy link
Author

IBwWG commented Aug 30, 2016

With the latest code, renaming works now, sometimes. It just let me rename 2 entries, but then after that would not let me rename any more. Meanwhile each attempt still leaks 200 MB.

@ndee85
Copy link
Owner

ndee85 commented Aug 30, 2016

This is strange... does it also happen for a newly setup file? If not, could you provide a blend?

@IBwWG
Copy link
Author

IBwWG commented Aug 30, 2016

I think I actually need to triple-click before anything happens. That seems to be consistently it. Double-clicking just leaks memory. I'll try on a fresh file.

@IBwWG
Copy link
Author

IBwWG commented Aug 30, 2016

On a fresh file, double-clicking works fine to rename, although still leaks a few 100 KB, but only after the rename. Maybe it's a lag issue.

@IBwWG
Copy link
Author

IBwWG commented Aug 30, 2016

Here it is:

  1. fresh file
  2. import my four sprite sheet files (totaling 4 MB) using coa_tools Import Sprites
  3. create new collection with coa_tools + icon
  4. double click NewCollection

Every time you do that fourth step, it doesn't let you rename, and leaks 35 MB.

@IBwWG
Copy link
Author

IBwWG commented Aug 30, 2016

OK given my comment in the other thread I'm going to close this, because it seems clear from the numbers that, once there's actually data to work with, the lag causes a double click to register as two single clicks, leaking twice the amount of memory. So this is actually just a side-effect of #37.

@IBwWG IBwWG closed this as completed Aug 30, 2016
@ndee85
Copy link
Owner

ndee85 commented Aug 30, 2016

yep. Lets discuss the rest in #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants