Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion to deprecate the module #7

Closed
BridgeAR opened this issue May 8, 2020 · 3 comments · Fixed by #8
Closed

Suggestion to deprecate the module #7

BridgeAR opened this issue May 8, 2020 · 3 comments · Fixed by #8

Comments

@BridgeAR
Copy link
Contributor

BridgeAR commented May 8, 2020

@ndelangen as I tried to outline in storybookjs/storybook#7445 (comment) it's probably a good idea to deprecate the module.

I am willing to open a PR that e.g., indicates that in the README, if that would help.
@ndelangen
Copy link
Owner

Sure, that would certainly help!

@BridgeAR
Copy link
Contributor Author

@ndelangen would be fine with a more "prominent" approach as in replacing the whole README or do you favor just adding a short note at the top?

@ndelangen
Copy link
Owner

ndelangen commented May 11, 2020 •
edited

Short at the top please, since for the foreseeable future people will be using storybook v5 which uses this. And I don't want them to have to dig into the history to understand what this plugin does.

@BridgeAR BridgeAR mentioned this issue May 16, 2020
Merged
@ndelangen ndelangen mentioned this issue Aug 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: mark module as deprecated BridgeAR/corejs-upgrade-webpack-plugin
2 participants
@ndelangen @BridgeAR