nsupdate.sh may fail silently with exit status to be 0

[Gowee]

Hello,

I am adapting the sample hook script for Cloudflare API. I notice a possible problem that may cause the script to fail silently.

At the line

uacme/nsupdate.sh

Line 126 in 5edec0e

[ $res -eq 0 ] || break

, break is executed if ns_doupdate returns non-zero code. Then it flows to the line

uacme/nsupdate.sh

Line 136 in 5edec0e

return $?

, where $? is always 0 because previous res=$? (and [ $res -eq 0 ] ?) itself updates $? to be 0.

Finally, the script returns 0 even though ns_doupdate has failed.

A quick fix is to replace break with return $res.

(I do not have a bind server to test the original script. Please let me know if I missed something by mistake.)