Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send emails until after updating the state #24

Open
ndmitchell opened this issue Aug 7, 2015 · 0 comments
Open

Don't send emails until after updating the state #24

ndmitchell opened this issue Aug 7, 2015 · 0 comments

Comments

@ndmitchell
Copy link
Owner

Currently on merge the server takes the state variable, sends emails, does the merge, then updates the state. That can mean there are 5 minutes when the user can visit the web page and it shows the code is not merged, and yet they have an email saying it was merged. Generally, emails should lag the web page.

Solution is probably to replace the emailNotify function in oven with one that queues things up and sends them after. At the same time I can refactor to make emailNotify total and then not worry about error handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant