Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TelegramParser.parse should receive raw bytestring #17

Closed
ndokter opened this issue Jan 4, 2017 · 1 comment
Closed

TelegramParser.parse should receive raw bytestring #17

ndokter opened this issue Jan 4, 2017 · 1 comment
Assignees

Comments

@ndokter
Copy link
Owner

ndokter commented Jan 4, 2017

A small refactoring of the way DSMRProtocol and SerialReader feed data into TelegramParser.parse. This currently consists of a list of strings.

The preferred solution is that TelegramParser.parse will accept a single bytestring as outputted by the meter without any alterations. This removes any form of logic in the clients themselves and will also sort issues with line endings (see pull request #15)

@ndokter
Copy link
Owner Author

ndokter commented Jan 5, 2017

Thinking about going for str instead of bytes so it's easier to integrate into python 2.x.

@ndokter ndokter closed this as completed Jan 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant