Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-43: IntelliJ plugin supports both new and legacy package names #45

Merged
merged 2 commits into from May 16, 2022

Conversation

DanielJette
Copy link
Contributor

@DanielJette DanielJette commented May 16, 2022

What does this change accomplish?

Add support for both new and legacy package names to the IntelliJ plugin.
Resolves #43

How have you achieved it?

Users will likely take some time to migrate from the com.shopify namespace to the new dev.testify namespace. During this transition, they may be using newer versions of Android Studio (Dolphin, Electric Eel) which are not supported by the legacy plugin. To facilitate this transition, the plugin can support both new and legacy package names.

Tophat instructions

  1. In any supported version of Android Studio, install the pre-built plugin from IntelliJ-1.2.0-alpha02.jar.zip

New package

  1. Open the current Sample source code in the preview build of Android Studio.
  2. Verify that the 馃摲 icon is present in the screenshot test files and that the various commands work as expected.

Legacy Package

  1. Checkout the legacy codebase from https://github.com/Shopify/android-testify
  2. Open the legacy project Sample
  3. Verify that the 馃摲 icon is present in the screenshot test files and that the various commands work as expected.

@DanielJette
Copy link
Contributor Author

@DanielJette DanielJette marked this pull request as ready for review May 16, 2022 00:32
Copy link
Collaborator

@jaredh jaredh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described 馃憤

@DanielJette DanielJette merged commit 0c66cec into main May 16, 2022
@DanielJette DanielJette deleted the issue-43/support-legacy-package-name branch May 16, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update IntelliJ plugin to support both current and legacy package names
2 participants