Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font scale configuration for Compose tests #95

Closed
1 of 5 tasks
ryansama opened this issue Sep 19, 2022 · 2 comments · Fixed by #104
Closed
1 of 5 tasks

Font scale configuration for Compose tests #95

ryansama opened this issue Sep 19, 2022 · 2 comments · Fixed by #104
Labels
Feedback Library Relates to the Testify Kotlin library: ScreenshotRule, ScreenshotInstrumentation, etc. Testify 2.0
Milestone

Comments

@ryansama
Copy link

ryansama commented Sep 19, 2022

Is your feature request related to a problem? Please describe.
Absolutely love that we can configure font scales by creating our own test activity that implements TestifyResourcesOverride. Would be great to update ComposableTestActivity to implement TestifyResourcesOverride so that font scale or locale can be configured out-of-the-box for Jetpack Compose tests.

This feedback relates to:

  • The Kotlin library
  • The Gradle plugin
  • The IntelliJ Platform plugin
  • The sample code
  • The documentation

Describe the solution you'd like
Update ComposableTestActivity to implement TestifyResourcesOverride so that font scale or locale can be configured for Jetpack Compose tests.

Describe alternatives you've considered
Alternatively we could update ComposableScreenshotRule to optionally accept a custom activity, much like ScreenshotRule.

Additional context
N/A

@DanielJette
Copy link
Contributor

Hi @ryansama. Thanks for the feature request. This is a great idea and I think it should be straightforward to add. I'll add this to our backlog for the 2.0 final release.

@DanielJette DanielJette added this to the 2.0.0 milestone Sep 20, 2022
@DanielJette DanielJette added Library Relates to the Testify Kotlin library: ScreenshotRule, ScreenshotInstrumentation, etc. Testify 2.0 labels Sep 20, 2022
@DanielJette
Copy link
Contributor

Fix for this was published in 2.0.0-alpha02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feedback Library Relates to the Testify Kotlin library: ScreenshotRule, ScreenshotInstrumentation, etc. Testify 2.0
Projects
None yet
2 participants