-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rendering of inline images with relative paths is not working #23
Comments
Hey tciecka Thanks for the examples. I will have a look to handle this and release a bugfix. Thanks |
Hi @tciecka I just released a new version 0.7.1. It should fix your issue by adding the ability to reference local files, relatively and absolutely. You have to add the protocol file:/// in front of every reference, otherwise it is not detected. This is to stay consistent with the http and https protocol/scheme checks internally. My test included:
Everything was loaded correctly. If the path is relative, the path of the current file is used. If the file has not been saved it does not work, obviously ^^' I hope this helps your documentation and my test cases were enough to filter everything out. If not, just let me know. Sorry for the long time to fix but Cheers :) |
Hello nea,
It's easier to understand and shorter to write. Markdown doesn't have common standard for this, but here and here you find the proposal:
I also use ReText and it works with images same way. |
Hey @andrewanswer Thanks a lot ^^ Cheers |
I just wanted to note, that on github for example ,using the file:/// prefix for local doesn't work when viewed on line. |
Neither GitHub's Markdown renderer, nor Pandoc support "file:///" URI (security concerns?) Thus, requiring local files to be referred with "file" scheme makes Markdown files not really portable. Please allow bare file paths (or ",/path") in the image statements |
Hi, I think this should be re-opened because (1) the I'm not demanding a fix (though we'd love one 😉), just suggesting it be left open to reflect the current status of things. |
Spaces do not seem to be picked up correctly using images. |
also this issue post is from 2017 🤷♀ u can claim this is 'for personal use only' but your plugin shows up in the notpad++ plugin browser.. |
i would suggest anyone looking for a markdown editor to use the "Markdown Panel" plugin that can be found through the plugin browser in notepad ++ instead. |
Adding "file:///", Exactly "View" works. but "Export as" doesn't work. |
The viewer panel does not render images that are in a path relative to the file being edited. It does render remote images just fine, however. Examples have been included that demonstrate a failed render and a successful render. In both cases, the Export/HTML command will produce a document that is able to render in a browser since the links are properly formatted in both example cases.
Example1 - render failure:
![Test](./images/someImage.png)
Example2 - render success:
![alt text](https://github.com/adam-p/markdown-here/raw/master/src/common/images/icon48.png)
The text was updated successfully, but these errors were encountered: