Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support side-effect CSS imports #406

Open
Tracked by #368
andy-haynes opened this issue Apr 9, 2024 · 2 comments
Open
Tracked by #368

Support side-effect CSS imports #406

andy-haynes opened this issue Apr 9, 2024 · 2 comments

Comments

@andy-haynes
Copy link
Contributor

andy-haynes commented Apr 9, 2024

Add support for importing (plain?) stylesheets, e.g.

import '@radix-ui/themes/styles.css';

I'm assuming would entail a kind of build time CSS side loading to get the desired effect, opening the door to potential collisions at best and malicious UI tampering at worst. However if this behavior is limited to the root container, we could probably support this in a non-problematic way.

@mpeterdev
Copy link
Collaborator

mpeterdev commented Apr 12, 2024

possible duplicate of #383

technically different import strategy but likely the same end result

@andy-haynes
Copy link
Contributor Author

I think this would still be a separate (albeit related) issue because supporting the import in JS would require a very different implementation. But to be honest I'm still not sure what exactly this does in a JS module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants