docs: FAQ updates #144
Merged
docs: FAQ updates #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
andy-haynes
commented
Nov 17, 2023
| > @andy (very high level summary then link to architecture doc) | ||
| Containers maintain a set of callbacks, defined within the container, which are available to be "invoked" across container boundaries. This includes functions passed via `props` and function arguments passed to `props` functions. When an external container needs to invoke one of these callbacks, the external container requests the outer application to send a message to the target container identifying the method and arguments. | ||
|
|
||
| See [architecture.md](architecture.md#component-callbacks) for more details. | ||
|
|
||
| #### What are the downsides of using iframes? |
There was a problem hiding this comment.
This is a bit broad - what are we trying to answer here?
Are we contrasting iframes to other solutions listed in this document? Enumerating the constraints this imposes on BWE?
There was a problem hiding this comment.
I was going for enumerating the constraints it imposes on BWE. If you don't feel its a valid FAQ entry it can be dropped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the FAQ document with more context on callbacks and other implementation details.
Fixes #143