feat: state enhancements and fixes #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
andy-haynes
commented
Sep 15, 2023
| @@ -9,7 +9,10 @@ export function parseChildComponentPaths(transpiledWidget: string) { | |||
| const source = match.groups?.src; | |||
| widgetInstances[source] = { | |||
| source, | |||
| transform: (widgetSource: string, widgetComponentName: string) => widgetSource.replaceAll(match[0], match[0].replace('Widget', widgetComponentName)), | |||
| transform: (widgetSource: string, widgetComponentName: string) => { | |||
| const signaturePrefix = `${widgetComponentName},{__bweMeta:{parentMeta:props.__bweMeta},`; | |||
There was a problem hiding this comment.
Injecting this into each child Component's call site is how parentMeta is chained along. This is not a great way to do it, might be cleaner to modify the AST directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Component state logic to allow trusted Component instances to parse their own IDs dynamically. This is done with the use of a
parentMetaproperty on the__bweMetaobject, analogous to prototype chains.