New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace isTrusted
#79
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I am a fan of including that out of the gate 👍 |
andy-haynes
force-pushed
the
feat/trust-prop
branch
from
October 7, 2023 00:12
5c51d65
to
37af28a
Compare
andy-haynes
force-pushed
the
feat/trust-prop
branch
from
October 7, 2023 00:14
37af28a
to
e86d938
Compare
andy-haynes
force-pushed
the
feat/trust-prop
branch
from
October 7, 2023 00:16
e86d938
to
5d43c84
Compare
|
andy-haynes
force-pushed
the
feat/trust-prop
branch
from
October 7, 2023 00:22
5d43c84
to
e2fbe40
Compare
andy-haynes
force-pushed
the
feat/trust-prop
branch
from
October 7, 2023 00:27
e2fbe40
to
b765f16
Compare
andy-haynes
force-pushed
the
feat/trust-prop
branch
from
October 9, 2023 17:54
b765f16
to
8256004
Compare
andy-haynes
force-pushed
the
feat/trust-prop
branch
from
October 9, 2023 18:00
8256004
to
622788e
Compare
andy-haynes
force-pushed
the
feat/trust-prop
branch
from
October 9, 2023 18:02
622788e
to
d952b23
Compare
andy-haynes
force-pushed
the
feat/trust-prop
branch
from
October 9, 2023 18:12
d952b23
to
b136170
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
isTrusted
flag with an object undertrust
to accommodate more complex loading strategies in the future. Fixes #72Before:
After:
The options in the current implementation are implemented here as values for
mode
:sandboxed
ortrusted
. In the updated implementation (#73), Components without a value specified are assumed to besandboxed
.As part of this PR I've also included a
trust-authortrusted-author
trust mode, which treats all Components as trusted if they have the same author as the Component loaded with this trust mode. However explicitly indicatingsandboxed
mode overrides this blanket trust for individual Components and their descendants:We can merge this without
trust-authortrusted-author
, I've included it here because: