Linting+formatting pre-commit hook #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pre-commit hook via husky that prevents committing if formatting or linting check does not pass.
Going ahead and PRing this now with it only enabled for the outer window application package, but it will be extended to all other packages as well.
The nice thing about doing this with turbo is that lint+format checks will return an immediate cached success for any packages which have not been touched
Also switches to a more restrictive
turboversion since usinglatestcould lead us to installing a higher without performing requisite migrations. We will get prompts when new versions are available, so this shouldn't hinder us from keeping up to date with latest